From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Return-Path: <gorcunov@gmail.com>
Date: Mon, 18 Mar 2019 21:07:06 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Subject: Re: [PATCH] lib/core/fiber: Initialize stack_watermark where
 appropriate
Message-ID: <20190318180706.GC2469@uranus.lan>
References: <20190318172352.14128-1-gorcunov@gmail.com>
 <20190318175246.22utl4hoc3jnxuk2@esperanza>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190318175246.22utl4hoc3jnxuk2@esperanza>
To: Vladimir Davydov <vdavydov.dev@gmail.com>
Cc: tml <tarantool-patches@freelists.org>
List-ID: <tarantool-patches.dev.tarantool.org>

On Mon, Mar 18, 2019 at 08:52:46PM +0300, Vladimir Davydov wrote:
> On Mon, Mar 18, 2019 at 08:23:52PM +0300, Cyrill Gorcunov wrote:
> > The stack_watermark member declared with HAVE_MADV_DONTNEED wrap,
> > so need to guard it here the same way.
> 
> Yep, overlooked it, my bad. I also lost fiber_stack_recycle() stub.
> Weird, but it did compile on OS X as is. Looks like OS X supports
> MADV_DONTNEED after all :)
> 
> Applied to 2.1 and 1.10 with fiber_stack_recycle() fix squashed.
> Thanks!

Thanks! It was actually my nit in first place ;)