From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Fri, 15 Mar 2019 18:58:12 +0300 From: Vladimir Davydov Subject: Re: [PATCH] test: fix vinyl/deferred_delete failure Message-ID: <20190315155812.bk3xq6hffbphifg4@esperanza> References: <5433435d6f2cdc0c5524df649f39deb7d02d1dce.1552665465.git.vdavydov.dev@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5433435d6f2cdc0c5524df649f39deb7d02d1dce.1552665465.git.vdavydov.dev@gmail.com> To: tarantool-patches@freelists.org List-ID: On Fri, Mar 15, 2019 at 06:57:51PM +0300, Vladimir Davydov wrote: > The patch fixes the following test failure: > > | --- vinyl/deferred_delete.result Fri Mar 15 18:17:05 2019 > | +++ vinyl/deferred_delete.reject Fri Mar 15 18:18:18 2019 > | @@ -577,7 +577,7 @@ > | ... > | sk:stat().rows -- ditto > | --- > | -- 5 > | +- 25 > | ... > | s:drop() > | --- > > The failure was introduced by commit 6dd0d2fb7e0e ("vinyl: do not apply > run_count_per_level to the last level"). Due to the commit compaction of > the secondary index may happen before compaction of the primary index, > in which case deferred DELETE statements won't make it to the secondary > index in time against the test expectation. Fix this by making the first > run big enough to prevent major compaction from kicking in. > > Follow-up #3657 > Closes #4047 > --- > test/vinyl/deferred_delete.result | 36 ++++++++++++++++++++++-------------- > test/vinyl/deferred_delete.test.lua | 18 ++++++++++++------ > 2 files changed, 34 insertions(+), 20 deletions(-) Trivial. Pushed to 2.1.