From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Fri, 15 Mar 2019 17:09:48 +0300 From: Vladimir Davydov Subject: Re: [PATCH] test: don't leave open read views after vinyl/iterator Message-ID: <20190315140948.47d46ucgf5liu74o@esperanza> References: <65061cb4d595bdc09ac1bda50a0dfed090438950.1552658906.git.vdavydov.dev@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <65061cb4d595bdc09ac1bda50a0dfed090438950.1552658906.git.vdavydov.dev@gmail.com> To: tarantool-patches@freelists.org List-ID: On Fri, Mar 15, 2019 at 05:09:03PM +0300, Vladimir Davydov wrote: > An open iterator may disrupt the following test run, because it may > prevent dump/compaction from purging stale rows. In particular, > iterators left by vinyl/iterator result in the following test failure: > > | --- vinyl/deferred_delete.result Mon Feb 11 19:14:01 2019 > | +++ vinyl/deferred_delete.reject Fri Mar 15 16:21:11 2019 > | @@ -155,7 +155,7 @@ > | ... > | pk:stat().rows -- 5 new REPLACEs > | --- > | -- 5 > | +- 10 > | ... > | i1:stat().rows -- 10 old REPLACE + 5 new REPLACEs + 10 deferred DELETEs > | --- > > Fix this by calling the Lua garbage collector to delete all dangling > iterators in the end of vinyl/iterator test. > > Closes #3862 > --- > https://github.com/tarantool/tarantool/issues/3862 > > test/vinyl/iterator.result | 13 +++++++++++++ > test/vinyl/iterator.test.lua | 6 ++++++ > 2 files changed, 19 insertions(+) Trivial. Pushed to 2.1.