From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 13 Mar 2019 12:00:46 +0300 From: Konstantin Osipov Subject: Re: [PATCH v2 04/14] vinyl: don't use IPROTO_SELECT type for key statements Message-ID: <20190313090046.GD25066@chai> References: <153662577da26d29a53bea2368ab624e9d2a058b.1552464666.git.vdavydov.dev@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <153662577da26d29a53bea2368ab624e9d2a058b.1552464666.git.vdavydov.dev@gmail.com> To: Vladimir Davydov Cc: tarantool-patches@freelists.org List-ID: * Vladimir Davydov [19/03/13 11:53]: > To differentiate between key and tuple statements in comparators, we set > IPROTO_SELECT type for key statements. As a result, we can't use key > statements in the run iterator directly although secondary index runs do > store statements in key format. Instead we create surrogate tuples > filling missing fields with NULLs. This won't play nicely with multikey > indexes so we need to teach iterators to deal with statements in key > format. The first step in this direction is dropping IPROTO_SELECT in > favor of identifying key statements by format. OK to push. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov