From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kostja@tarantool.org>
Date: Wed, 13 Mar 2019 11:59:24 +0300
From: Konstantin Osipov <kostja@tarantool.org>
Subject: Re: [PATCH v2 03/14] vinyl: rename key stmt construction routine
Message-ID: <20190313085924.GC25066@chai>
References: <cover.1552464666.git.vdavydov.dev@gmail.com>
 <e81b19b4e62aa630aa7129800f088ba989e3ca77.1552464666.git.vdavydov.dev@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <e81b19b4e62aa630aa7129800f088ba989e3ca77.1552464666.git.vdavydov.dev@gmail.com>
To: Vladimir Davydov <vdavydov.dev@gmail.com>
Cc: tarantool-patches@freelists.org
List-ID: <tarantool-patches.dev.tarantool.org>

* Vladimir Davydov <vdavydov.dev@gmail.com> [19/03/13 11:53]:
> Currently, it's called vy_stmt_new_select, but soon a key statement will
> be allowed to have any type, not just IPROTO_SELECT. So let's rename it
> to vy_stmt_new_key. Let's also rename the wrapper vy_key_from_msgpack to
> vy_stmt_new_key_from_msgpack to be consistent with vy_stmt_new_key.

OK to push. I would call it vy_key_new() and
vy_key_new_from_msgpack, if these names are not used. 


-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov