From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 12 Mar 2019 11:54:24 +0300 From: Vladimir Davydov Subject: Re: [tarantool-patches] Re: [PATCH v2 1/1] http: fix httpc auto-managed headers Message-ID: <20190312085424.7bdiyruwy3oxdrfq@esperanza> References: <80130a1b-84ad-5f90-9422-95bb0a1e67cb@tarantool.org> <998b800b-acc1-f0c8-1fd3-322d0c04f657@tarantool.org> <20190307135135.dner6r66szejw6lx@esperanza> <22400748-d82b-16ab-5809-68440cbfb1ef@tarantool.org> <20190307145328.ublvmnnyxvowgxl3@esperanza> <20190311100221.3oudvbsfaq4gxawb@esperanza> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: To: Kirill Shcherbatov Cc: tarantool-patches@freelists.org List-ID: On Mon, Mar 11, 2019 at 06:57:54PM +0300, Kirill Shcherbatov wrote: > The http library intelligently sets the headers "Accept", > "Connection", "Keep-Alive". > However, when the user explicitly specified them in the header > options section of the call argument, they could be written to > the HTTP request twice. > We postponed the auto headers setup before https_exececute call. > Now they are set only if they were not set by the user. > > Closes #3955 > > https://github.com/tarantool/tarantool/tree/kshch/gh-3955-httpc-auto-managed-headers-redefine > https://github.com/tarantool/tarantool/issues/3955 > --- > src/httpc.c | 52 +++++++++++++++++++++---------- > src/httpc.h | 23 +++++++++++++- > src/lua/httpc.c | 6 +--- > test/app-tap/http_client.test.lua | 36 ++++++++++++++++++++- > 4 files changed, 94 insertions(+), 23 deletions(-) Pushed to 2.1 and 1.10.