From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id EFF9424B2A
for <tarantool-patches@freelists.org>; Mon, 11 Mar 2019 04:23:44 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
with ESMTP id 1iFWoPKecDMQ for <tarantool-patches@freelists.org>;
Mon, 11 Mar 2019 04:22:20 -0400 (EDT)
Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com [209.85.208.179])
(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
(No client certificate requested)
by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 4C1C72770F
for <tarantool-patches@freelists.org>; Mon, 11 Mar 2019 04:18:25 -0400 (EDT)
Received: by mail-lj1-f179.google.com with SMTP id d24so3155200ljc.12
for <tarantool-patches@freelists.org>; Mon, 11 Mar 2019 01:18:25 -0700 (PDT)
Date: Mon, 11 Mar 2019 11:18:22 +0300
From: Konstantin Osipov <kostja.osipov@gmail.com>
Subject: [tarantool-patches] Re: [PATCH v3 2/2] Transaction support for
applier
Message-ID: <20190311081822.GI3101@chai>
References: <cover.1552248901.git.georgy@tarantool.org>
<44e943ca39bcba8a2f1cb06274d6dea0af74e162.1552248901.git.georgy@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <44e943ca39bcba8a2f1cb06274d6dea0af74e162.1552248901.git.georgy@tarantool.org>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-Help: <mailto:ecartis@freelists.org?Subject=help>
List-Unsubscribe: <mailto:tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-Subscribe: <mailto:tarantool-patches-request@freelists.org?Subject=subscribe>
List-Owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-Archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org
Cc: Georgy Kirichenko <georgy@tarantool.org>
* Georgy Kirichenko <georgy@tarantool.org> [19/03/11 09:55]:
> Applier fetch incoming rows to form a transaction and then apply it.
> Rows are fetched and stored on fiber gc region until last transaction row
> with is_commit was fetched. After fetch a multi row transaction is going to be
> applied into txn_begin/txn_commit/txn_rolback boundaries. At this time
> we could not apply single row transaction in such boundaries because of
> ddl which does not support non auto commit transactions.
The patch is generally looking good to me, but I assume it depends
on the first patch which changes the gc memory life cycle
boundaries. Is it possible to fix this patch so that it doesn't
depend on the first patch?
Besides, I asked in the previous review for a test case involving
on_replace/before_replace triggers.
--
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov