From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 548A624745 for ; Mon, 11 Mar 2019 04:12:49 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qr-Su5o-RwN5 for ; Mon, 11 Mar 2019 04:12:46 -0400 (EDT) Received: from mail-lj1-f173.google.com (mail-lj1-f173.google.com [209.85.208.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id E582D216E2 for ; Mon, 11 Mar 2019 04:12:44 -0400 (EDT) Received: by mail-lj1-f173.google.com with SMTP id z25so3163757ljk.8 for ; Mon, 11 Mar 2019 01:12:44 -0700 (PDT) Date: Mon, 11 Mar 2019 11:12:42 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH] Don't free fiber gc on while txn_rollback Message-ID: <20190311081242.GG3101@chai> References: <102d071dcc331779234ab7ae1a6d90aa238c9f14.1552245126.git.georgy@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <102d071dcc331779234ab7ae1a6d90aa238c9f14.1552245126.git.georgy@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: Georgy Kirichenko * Georgy Kirichenko [19/03/11 09:55]: > In some cases volatile memory should be usable after txn_rollback > invocation. So move fiber_gx to the box_txn_rollback from the > txn_rollback. txn_rollback() is used in a bunch of places - call.c, transaction rollback in case of error. Are we going to leave the memory behind now in such cases? What exactly do you need this change for, what case? Could you please write in a changeset comment? It would also be nice if you turned on spell checking in your git commit message editor. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov