From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id E219D26D86 for ; Thu, 7 Mar 2019 08:40:41 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id u0M2k-IqxL7K for ; Thu, 7 Mar 2019 08:40:41 -0500 (EST) Received: from smtp40.i.mail.ru (smtp40.i.mail.ru [94.100.177.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id A0FBF24286 for ; Thu, 7 Mar 2019 08:40:41 -0500 (EST) Date: Thu, 7 Mar 2019 16:40:39 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH 4/4] sql: replace BLOB as column type with SCALAR Message-ID: <20190307134039.GF24636@chai> References: <83426c95235d880a4d16ca84927138961caf3c55.1551964360.git.korablev@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <83426c95235d880a4d16ca84927138961caf3c55.1551964360.git.korablev@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: v.shpilevoy@tarantool.org, Nikita Pettik * Nikita Pettik [19/03/07 16:18]: > BLOB column type is represented by SCALAR field type in terms of NoSQL. > We attempted at emulating BLOB behaviour, but such efforts turn out to > be not decent enough. For this reason, we've decided to abandon these > attempts and fairly replace it with SCALAR column type. SCALAR column > type acts in the same way as it does in NoSQL: it is aggregator-type for > INTEGER, NUMBER and STRING types. So, column declared with this type can > contain values of these three (available in SQL) types. It is worth > mentioning that CAST operator in this case does nothing. > Shouldn't we keep the BLOB keyword in the list of reserved words? The same applies to DATE/TIME and other words which are reserved in SQL standard. The patch itself LGTM. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov