From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 7 Mar 2019 14:22:35 +0300 From: Konstantin Osipov Subject: Re: [tarantool-patches] Re: [PATCH v2 2/3] Put all new rows to the end of journal request Message-ID: <20190307112235.GJ5263@chai> References: <2134b8fca0963ebd0a8fb818a66cd05e81ef09a6.1551902962.git.georgy@tarantool.org> <20190307103813.GF5263@chai> <20190307105321.ru5lpevqnuvg4b6u@esperanza> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190307105321.ru5lpevqnuvg4b6u@esperanza> To: Vladimir Davydov Cc: tarantool-patches@freelists.org, Georgy Kirichenko List-ID: * Vladimir Davydov [19/03/07 13:57]: > > txn->n_rows[stmt->replica_id == instance_id] ++; > > TBO I find it hackish. > > n_remote_rows / n_rows looks much easier for understanding IMO. It's n_local_rows and n_remote_rows then. Why do we need the total and the partial sum then? -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov