From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id CF214292E5 for ; Thu, 7 Mar 2019 05:16:50 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JtyJz-Y7dJnj for ; Thu, 7 Mar 2019 05:16:50 -0500 (EST) Received: from smtp45.i.mail.ru (smtp45.i.mail.ru [94.100.177.105]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 88E2F29239 for ; Thu, 7 Mar 2019 05:16:50 -0500 (EST) Date: Thu, 7 Mar 2019 13:16:47 +0300 From: Kirill Yukhin Subject: [tarantool-patches] Re: [PATCH v1 1/1] box: fix custom delimiter for telnet connection Message-ID: <20190307101647.x2qmmzzxmngslmkg@tarantool.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: alexander.turenko@tarantool.org, Kirill Shcherbatov Hello, On 21 Feb 10:34, Kirill Shcherbatov wrote: > Because test-run uses a console connection to run tests, the > actual string delimiter was the user-specified delimiter > delim + "\n". > Since telnet sends \r\n on line break, the updated expression > delim + "\n"could not be found in a sequence data+delim+"\r\n", > so delimiter feature did not work at all. > Added delim + "\r" check along with delim + "\n", that solves the > described problem and does not violate backward compatibility. > > Closes #2027 > > https://github.com/tarantool/tarantool/tree/kshch/gh-2027-telnet-alternative-delimiter > https://github.com/tarantool/tarantool/issues/2027 I've committed your patch into 2.1 branch. -- Regards, Kirill Yukhin