From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id A8A3028C30 for ; Wed, 6 Mar 2019 04:48:05 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id viVxC4DJMoHh for ; Wed, 6 Mar 2019 04:48:05 -0500 (EST) Received: from mail-lf1-f67.google.com (mail-lf1-f67.google.com [209.85.167.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 3902028C05 for ; Wed, 6 Mar 2019 04:48:05 -0500 (EST) Received: by mail-lf1-f67.google.com with SMTP id u2so1478132lfd.4 for ; Wed, 06 Mar 2019 01:48:05 -0800 (PST) Date: Wed, 6 Mar 2019 12:48:02 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH v4] Feature request for a new collation Message-ID: <20190306094802.GH17432@chai> References: <20190305114431.31311-1-szudin@tarantool.org> <20190305154146.GA6860@chai> <35d9a188-03ec-b177-a039-650f15da1fa0@tarantool.org> <20190306081152.GF17432@chai> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: Stanislav Zudin Cc: tarantool-patches@freelists.org * Stanislav Zudin [19/03/06 11:26]: > > > On 06.03.2019 11:11, Konstantin Osipov wrote: > > * Stanislav Zudin [19/03/06 10:24]: > > > > > > > > > On 05.03.2019 18:41, Konstantin Osipov wrote: > > > > * Stanislav Zudin [19/03/05 14:45]: > > > > > /** Maximal length of locale name. */ > > > > > enum { > > > > > - COLL_LOCALE_LEN_MAX = 16, > > > > > + COLL_LOCALE_LEN_MAX = 1024, > > > > > }; > > > > > > > > Why? > > > > > > > > > > Because locale may include numerous options such as collation, numbers, > > > calendar etc. e.g.: "fr@collation=phonebook;calendar=islamic-civil". > > > The max length is not specified. > > > > *Nobody* except us can add a new collation. The names of the > > collations you added don't exceed 16 bytes. Please keep the old > > value. > > > strlen("de_DE_u_co_phonebk") == 18. + "unicode_", then, increase to a relevant value please. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov