From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 5 Mar 2019 19:58:05 +0300 From: Alexander Turenko Subject: Re: [tarantool-patches] [PATCH] Disable bad url http client test only for OSX Message-ID: <20190305165805.a3jl57znx5ydzzuj@tkn_work_nb> References: <20190228081302.17329-1-sergw@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190228081302.17329-1-sergw@tarantool.org> To: Sergei Voronezhskii Cc: tarantool-patches@freelists.org, Kirill Yukhin , Vladimir Davydov List-ID: It seems it just another incarnation of #3418, #3973 and #4005, because the following patch helps me (on a Mac OS machine). diff --git a/src/lib/core/fiber.c b/src/lib/core/fiber.c index abd6c6b11..529acf2d5 100644 --- a/src/lib/core/fiber.c +++ b/src/lib/core/fiber.c @@ -95,7 +95,7 @@ enum { /* The minimum allowable fiber stack size in bytes */ FIBER_STACK_SIZE_MINIMAL = 16384, /* Default fiber stack size in bytes */ - FIBER_STACK_SIZE_DEFAULT = 65536 + FIBER_STACK_SIZE_DEFAULT = 8388608, }; /** Default fiber attributes */ I have updated #3564. WBR, Alexander Turenko. On Thu, Feb 28, 2019 at 11:13:02AM +0300, Sergei Voronezhskii wrote: > Fixes #3564 > --- > BRANCH: https://github.com/tarantool/tarantool/tree/sergw/fix-osx-http-client-test > BUILD: https://travis-ci.org/tarantool/tarantool/builds/498215296 > test/app-tap/http_client.test.lua | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/test/app-tap/http_client.test.lua b/test/app-tap/http_client.test.lua > index 5493dd4ff..8cf790a6e 100755 > --- a/test/app-tap/http_client.test.lua > +++ b/test/app-tap/http_client.test.lua > @@ -74,7 +74,7 @@ local function test_http_client(test, url, opts) > test:ok(r.body:match("hello") ~= nil, "body") > test:ok(tonumber(r.headers["content-length"]) > 0, > "content-length > 0") > - test:is(client.get("http://localhost:1/").status, 595, 'cannot connect') > + if jit.os == "OSX" then test:skip('osx skip') else test:is(client.get("http://localhost:1/").status, 595, 'cannot connect') end > > local r = client.request('GET', url, nil, opts) > test:is(r.status, 200, 'request') > @@ -204,8 +204,12 @@ local function test_errors(test) > test:ok(not status and string.find(json.encode(err), > "Unsupported protocol"), > "POST: exception on bad protocol") > - local r = http:get("http://do_not_exist_8ffad33e0cb01e6a01a03d00089e71e5b2b7e9930dfcba.ru") > - test:is(r.status, 595, "GET: response on bad url") > + if jit.os == "OSX" then > + test:skip('osx skip') > + else > + local r = http:get("http://do_not_exist_8ffad33e0cb01e6a01a03d00089e71e5b2b7e9930dfcba.ru") > + test:is(r.status, 595, "GET: response on bad url") > + end > end > > local function test_headers(test, url, opts) > -- > 2.18.0 > >