From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vdavydov.dev@gmail.com>
Date: Tue, 5 Mar 2019 17:40:04 +0300
From: Vladimir Davydov <vdavydov.dev@gmail.com>
Subject: Re: [tarantool-patches] [PATCH v4] Feature request for a new
 collation
Message-ID: <20190305144004.fvbm2mfwvyfsh76b@esperanza>
References: <20190305114431.31311-1-szudin@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20190305114431.31311-1-szudin@tarantool.org>
To: Stanislav Zudin <szudin@tarantool.org>
Cc: tarantool-patches@freelists.org, kostja@tarantool.org
List-ID: <tarantool-patches.dev.tarantool.org>

On Tue, Mar 05, 2019 at 02:44:31PM +0300, Stanislav Zudin wrote:
> Adds a new set of default collations.
> The collation 'unicode_ky_s1' supports the difference
> between Cyrillic letters 'Е' and 'Ё'. The standard case insensitive
> collation ('unicode_ci') doesn't distinguish these letters.
> 
> Closes #4007
> ---
> Branch: https://github.com/tarantool/tarantool/tree/stanztt/gh-4007-new-default-collation-2.1
> Issue: https://github.com/tarantool/tarantool/issues/4007

Whenever you resubmit a patch, please add a brief changelog here to
point what have changed. It jogs my memory. Something like this would
be fine:

Changes in v4:
 - Add collations for other languages
Changes in v3:
 - Upgrade schema to 2.1.2 instead of using 2.1.0.
...

> 
>  src/box/bootstrap.snap          | Bin 1867 -> 4485 bytes
>  src/box/lua/upgrade.lua         | 109 ++++++-
>  src/coll_def.h                  |   2 +-
>  test/box-py/bootstrap.result    |   2 +-
>  test/box/ddl.result             | 560 +++++++++++++++++++++++++++++++-
>  test/box/net.box.result         |   2 +-
>  test/sql-tap/collation.test.lua | 280 +++++++++++++++-
>  test/sql/collation.result       |   4 +-
>  test/sql/collation.test.lua     |   4 +-
>  9 files changed, 943 insertions(+), 20 deletions(-)
> 
> diff --git a/src/box/lua/upgrade.lua b/src/box/lua/upgrade.lua
> index 09af2e20d..58b5d47cc 100644
> --- a/src/box/lua/upgrade.lua
> +++ b/src/box/lua/upgrade.lua
> @@ -615,7 +615,114 @@ local function upgrade_to_2_1_0()
>  end
>  
>  local function upgrade_to_2_1_2()
> -    box.space._collation:replace{4, "unicode_ru_s2", ADMIN, "ICU", "ru_RU", {strength='secondary'}}

Apparently, this patch is based on the previous version of the same
patch. Please don't do that. Squash it instead (see `git rebase -i` and
`git push -f`).

I won't be reviewing the rest of this patch, because I don't see much
point in adding collations for all those languates now. Up to Kostja.