From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 46869282D2 for ; Tue, 5 Mar 2019 04:43:56 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yRdPba-zXI5x for ; Tue, 5 Mar 2019 04:43:56 -0500 (EST) Received: from smtp32.i.mail.ru (smtp32.i.mail.ru [94.100.177.92]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id F3A6521898 for ; Tue, 5 Mar 2019 04:43:55 -0500 (EST) Date: Tue, 5 Mar 2019 12:43:53 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH v3 8/9] sql: rework three errors of "unsupported" type Message-ID: <20190305094353.GD21955@chai> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: Imeev Mergen * n.pettik [19/03/05 12:37]: > > + /*194 */_(ER_SQL_ANALYZE_ARGUMENT, "ANALYZE statement argument %s is not a base table") \ > > Why does this error deserve to be so special? I don't know. Should analyze work for a sysview? > To be honest, I would remove it at all and simply > do nothing in case of view is analysed. This would seep DBA mistakes under the carpet. > Or make it > raise not only for views, but in several other cases. > For instance, what if we analyse space without > format or indexes? Spoiler: it leads to assertion fault > > Assertion failed: (space->index_count != 0), function vdbe_emit_analyze_space, file /Users/n.pettik/tarantool/src/box/sql/analyze.c, line 799. > Abort trap: 6 This should work. Generally, I think it's bikeshed and not worth arguing about. Do you see any practical consequence from following my preference? > -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov