From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 5 Mar 2019 12:32:42 +0300 From: Konstantin Osipov Subject: Re: [tarantool-patches] Re: [rfc 4/4] core/fiber: Shrink stack when recycling Message-ID: <20190305093242.GC21955@chai> References: <20190302125524.279852704@gmail.com> <20190302130034.125890957@gmail.com> <20190305083048.GM21955@chai> <20190305084110.GM13301@uranus.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190305084110.GM13301@uranus.lan> To: tarantool-patches@freelists.org Cc: vdavydov.dev@gmail.com List-ID: * Cyrill Gorcunov [19/03/05 11:41]: > On Tue, Mar 05, 2019 at 11:30:48AM +0300, Konstantin Osipov wrote: > > * Cyrill Gorcunov [19/03/03 23:25]: > > > +#define wmark_freeze(_pp) do { *((uintptr_t *)(_pp)) |= (uintptr_t)1; } while (0) > > > +#define wmark_frozen(_p) ((uintptr_t)(_p) & (uintptr_t)1) > > > > Why not static inline? A comment would help. Usually the name for > > function returning true/false contains "is", e.g. wmark_is_frozen(). > > Well, surely we can use inlines here, I simply tried to make less code. > Seriously fiber.c looks too bloating. Maybe we should move all this > machinery into fiber-stack.cc? I am OK with moving things out (we prefer underscore to dash in file names though), but I tend to count code lines in the count of generated processor instructions, not characters/lines in a source file. > -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov