From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id A066026AC6 for ; Tue, 5 Mar 2019 04:13:43 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id a6rNBpWYCDy8 for ; Tue, 5 Mar 2019 04:13:43 -0500 (EST) Received: from smtp49.i.mail.ru (smtp49.i.mail.ru [94.100.177.109]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 5947E21190 for ; Tue, 5 Mar 2019 04:13:43 -0500 (EST) Date: Tue, 5 Mar 2019 12:13:40 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH 3/3] Transaction support for applier Message-ID: <20190305091340.GZ21955@chai> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: Georgy Kirichenko * Georgy Kirichenko [19/03/03 23:30]: > diff --git a/src/box/txn.c b/src/box/txn.c > index 7900fb3ab..f6bf72d0c 100644 > --- a/src/box/txn.c > +++ b/src/box/txn.c > @@ -34,6 +34,7 @@ > #include "journal.h" > #include > #include "xrow.h" > +#include "replication.h" What do you need this header for? instance_id? Is there a way to keep these two modules independent on each other? > + txn->n_remote_rows = 0; Just the same as in the previous patch, this name is very general. Could you please come up with something more specific? > + /** > + * Count of rows generated on a remote replica. > + */ > + int n_remote_rows; OK, now I know what this is, although I don't know what is "generated", but what is this for? Please write a better comment. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov