From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id BF8A3241CF for ; Tue, 5 Mar 2019 04:06:28 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mdpBWjt8cUWL for ; Tue, 5 Mar 2019 04:06:28 -0500 (EST) Received: from smtp31.i.mail.ru (smtp31.i.mail.ru [94.100.177.91]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 77EF220210 for ; Tue, 5 Mar 2019 04:06:28 -0500 (EST) Date: Tue, 5 Mar 2019 12:06:26 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH 2/3] Merge apply row and apply_initial_join_row Message-ID: <20190305090626.GX21955@chai> References: <1c0402648b0ce2f9a74bdd9cf4b95fb26e0fd297.1551644303.git.georgy@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1c0402648b0ce2f9a74bdd9cf4b95fb26e0fd297.1551644303.git.georgy@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: Georgy Kirichenko * Georgy Kirichenko [19/03/03 23:30]: > +/** > + * Memtx engine instance > + */ > +static struct memtx_engine *memtx = NULL; > +/** > + * Vinyl engine instance > + */ > +static struct vinyl_engine *vinyl = NULL; Would you have an instance for each engine? The idea with find_by_name() was that sometime in the future we will have storage engines entirely pluggable (no, this will not happen really). So I'm OK with ditching engine_by_name, but then the declaration should be in memtx_engine.h and vinyl_engine.h, respectively, or at least in engine.h, not in box.[hc] Re the patch itself, it's OK to push (I assume it helps moving apply_row into applier). -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov