From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 5F5BD255A1 for ; Tue, 5 Mar 2019 03:52:39 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GcKrM98vqXFg for ; Tue, 5 Mar 2019 03:52:39 -0500 (EST) Received: from smtp45.i.mail.ru (smtp45.i.mail.ru [94.100.177.105]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 165DE21B4D for ; Tue, 5 Mar 2019 03:52:39 -0500 (EST) Date: Tue, 5 Mar 2019 11:52:36 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH 1/3] Applier gets rid of a xstream Message-ID: <20190305085236.GW21955@chai> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: Georgy Kirichenko * Georgy Kirichenko [19/03/03 23:30]: > Remove xstream dependency and use direct box interface to apply all > replication rows. This is refactoring before transactional replication. Looks good to me. I would look into moving apply_row + apply_initial_join_row into applier.cc, although I see that it's re-used for wal_apply_row. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov