From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 832132802D for ; Tue, 5 Mar 2019 03:45:12 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dH5UgNDosPCD for ; Tue, 5 Mar 2019 03:45:12 -0500 (EST) Received: from smtp47.i.mail.ru (smtp47.i.mail.ru [94.100.177.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 3ADA726CE3 for ; Tue, 5 Mar 2019 03:45:12 -0500 (EST) Date: Tue, 5 Mar 2019 11:45:09 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH v3 6/9] sql: rework six syntax errors Message-ID: <20190305084509.GS21955@chai> References: <80be508ddcba4ffe5f5f4e99068ccce61e05a764.1551530224.git.imeevma@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <80be508ddcba4ffe5f5f4e99068ccce61e05a764.1551530224.git.imeevma@gmail.com> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: korablev@tarantool.org * imeevma@tarantool.org [19/03/03 23:25]: > This patch rewords six more syntax errors. > > Part of #3965 > --- > src/box/errcode.h | 3 +++ > src/box/sql/build.c | 4 +-- > src/box/sql/resolve.c | 62 +++++++++++++++++++++---------------------- > test/box/misc.result | 3 +++ > test/sql-tap/check.test.lua | 2 +- > test/sql-tap/colname.test.lua | 2 +- > 6 files changed, 40 insertions(+), 36 deletions(-) Please avoid adding a verb into error parameter and use singular: "Subqueries are" + "prohibited in ..." -> "A subquery" + "is prohibited in ..." Otherwise OK to push. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov