From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Date: Mon, 4 Mar 2019 13:32:34 +0300 From: Cyrill Gorcunov Subject: Re: [tarantool-patches] [PATCH v2] build: tags -- Exclude unneeded directories Message-ID: <20190304103234.GH13301@uranus.lan> References: <20190302144434.GC13301@uranus.lan> <20190302151013.GD13301@uranus.lan> <20190302154012.GE13301@uranus.lan> <20190304095734.cfuhxdzw6cajpm6x@esperanza> <20190304100942.GG13301@uranus.lan> <20190304101536.ch5uanhwt2z7uol4@esperanza> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190304101536.ch5uanhwt2z7uol4@esperanza> To: Vladimir Davydov Cc: tarantool List-ID: On Mon, Mar 04, 2019 at 01:15:36PM +0300, Vladimir Davydov wrote: > > > > > > > +list(APPEND tagsExclude "--exclude=.pc/*") > > > > > > What's in '.pc'? > > > > quilt uses it to stack data. > > AFAIK ctags will simply ignore those. It doesn't tag anything in .git > either. Come to think of it, do we really need to explicitly exclude > those dirs? yes we should, simply because it is pointless to force ctags to scan directory where we _know_ no useful data present, so it will process a bit faster. as to .pc -- quilt pushes there original .c|.h when a patch applied, so this generates unrelated tags and should be excluded from scanning. > > Guys, maybe we should simply tag src/ directory only? Or there someone > > who is using tags for tests, third party and etc? > > Tagging third_party is useful. We even patch those sometimes. > I'm not sure why it's not in src/ though. > > Tagging tests is mostly useless, you're correct, but it doesn't hurt > much. until one day :) but I don't insist > There's also a bunch of autogenerated files (e.g. *.lua.c and module.h). > I wonder if it makes sense to tag those. I guess it does. I think the same Cyrill