From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vdavydov.dev@gmail.com>
Date: Mon, 4 Mar 2019 13:15:36 +0300
From: Vladimir Davydov <vdavydov.dev@gmail.com>
Subject: Re: [tarantool-patches] [PATCH v2] build: tags -- Exclude unneeded
 directories
Message-ID: <20190304101536.ch5uanhwt2z7uol4@esperanza>
References: <20190302144434.GC13301@uranus.lan>
 <20190302151013.GD13301@uranus.lan>
 <20190302154012.GE13301@uranus.lan>
 <20190304095734.cfuhxdzw6cajpm6x@esperanza>
 <20190304100942.GG13301@uranus.lan>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190304100942.GG13301@uranus.lan>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tarantool <tarantool-patches@freelists.org>
List-ID: <tarantool-patches.dev.tarantool.org>

On Mon, Mar 04, 2019 at 01:09:43PM +0300, Cyrill Gorcunov wrote:
> On Mon, Mar 04, 2019 at 12:57:34PM +0300, Vladimir Davydov wrote:
> > > -add_custom_target(tags COMMAND ${CTAGS} -R -f tags
> > > +list(APPEND tagsExclude "--exclude=.git/*")
> > 
> > Great!
> > 
> > > +list(APPEND tagsExclude "--exclude=.pc/*")
> > 
> > What's in '.pc'?
> 
> quilt uses it to stack data.

AFAIK ctags will simply ignore those. It doesn't tag anything in .git
either. Come to think of it, do we really need to explicitly exclude
those dirs?

> Guys, maybe we should simply tag src/ directory only? Or there someone
> who is using tags for tests, third party and etc?

Tagging third_party is useful. We even patch those sometimes.
I'm not sure why it's not in src/ though.

Tagging tests is mostly useless, you're correct, but it doesn't hurt
much.

There's also a bunch of autogenerated files (e.g. *.lua.c and module.h).
I wonder if it makes sense to tag those. I guess it does.