From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vdavydov.dev@gmail.com>
Date: Mon, 4 Mar 2019 12:57:34 +0300
From: Vladimir Davydov <vdavydov.dev@gmail.com>
Subject: Re: [tarantool-patches] [PATCH v2] build: tags -- Exclude unneeded
 directories
Message-ID: <20190304095734.cfuhxdzw6cajpm6x@esperanza>
References: <20190302144434.GC13301@uranus.lan>
 <20190302151013.GD13301@uranus.lan>
 <20190302154012.GE13301@uranus.lan>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190302154012.GE13301@uranus.lan>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tarantool <tarantool-patches@freelists.org>
List-ID: <tarantool-patches.dev.tarantool.org>

On Sat, Mar 02, 2019 at 06:40:12PM +0300, Cyrill Gorcunov wrote:
> When building "tags" target we scan the whole working
> directory which is redundant. In particular .git,.pc,patches
> directories should not be scanned for sure.
> ---
>  v2:
>   - fix typos
> 
>  CMakeLists.txt |    5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> Index: tarantool.git/CMakeLists.txt
> ===================================================================
> --- tarantool.git.orig/CMakeLists.txt
> +++ tarantool.git/CMakeLists.txt
> @@ -137,7 +137,10 @@ check_function_exists(getprogname HAVE_G
>  #
>  # Enable 'make tags' target.
>  #
> -add_custom_target(tags COMMAND ${CTAGS} -R -f tags
> +list(APPEND tagsExclude "--exclude=.git/*")

Great!

> +list(APPEND tagsExclude "--exclude=.pc/*")

What's in '.pc'?

> +list(APPEND tagsExclude "--exclude=patches/*")
> +add_custom_target(tags COMMAND ${CTAGS} -R ${tagsExclude} -f tags
>      WORKING_DIRECTORY ${CMAKE_SOURCE_DIR})
>  add_custom_target(ctags DEPENDS tags)
>  
>