From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vdavydov.dev@gmail.com>
Date: Thu, 28 Feb 2019 18:31:53 +0300
From: Vladimir Davydov <vdavydov.dev@gmail.com>
Subject: Re: [PATCH] test: fix app/socket sporadic failure
Message-ID: <20190228153153.6aplzpm57trcr5bh@esperanza>
References: <216e0b14c8981ddbd110d2b4d9562194acdc7860.1551366539.git.vdavydov.dev@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <216e0b14c8981ddbd110d2b4d9562194acdc7860.1551366539.git.vdavydov.dev@gmail.com>
To: tarantool-patches@freelists.org
List-ID: <tarantool-patches.dev.tarantool.org>

On Thu, Feb 28, 2019 at 06:09:41PM +0300, Vladimir Davydov wrote:
> The patch fixes the following test failure:
> 
>  | --- app/socket.result	Mon Feb 25 17:32:49 2019
>  | +++ app/socket.reject	Mon Feb 25 17:39:51 2019
>  | @@ -2827,7 +2827,7 @@
>  |  ...
>  |  echo_fiber ~= nil
>  |  ---
>  | -- true
>  | +- false
>  |  ...
>  |  client:write('hello')
>  |  ---
> 
> This happens, because we don't wait for echo_fiber to start.
> Use a channel to make sure it does. Also, increase read/write
> timeouts from 0.1 up to 5 seconds - it won't increase the test
> runtime, but it will make it more robust.
> 
> Closes #4022
> ---
> https://github.com/tarantool/tarantool/issues/4022
> https://github.com/tarantool/tarantool/commits/dv/test-fixes
> 
>  test/app/socket.result   | 12 +++++++++---
>  test/app/socket.test.lua |  9 ++++++---
>  2 files changed, 15 insertions(+), 6 deletions(-)

Pushed to 2.1 and 1.10.