From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vdavydov.dev@gmail.com>
Date: Thu, 28 Feb 2019 18:31:11 +0300
From: Vladimir Davydov <vdavydov.dev@gmail.com>
Subject: Re: [PATCH v7] iproto: report active connections number
Message-ID: <20190228153111.swyqc3grur2fwgdt@esperanza>
References: <20190228141627.19799-1-i.kosarev@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190228141627.19799-1-i.kosarev@tarantool.org>
To: Ilya Kosarev <i.kosarev@tarantool.org>
Cc: tarantool-patches@freelists.org, georgy@tarantool.org, i.kosarev@corp.mail.ru
List-ID: <tarantool-patches.dev.tarantool.org>

On Thu, Feb 28, 2019 at 05:16:27PM +0300, Ilya Kosarev wrote:
> Now there is new member in box.stat.net() called "CONNECTIONS"
> which is a number of active iproto connections.
> 
> Closes #3905
> 
> @TarantoolBot document
> Title: box.stat.net
> Update the documentation for box.stat.net
> to reflect the addition of the field
> which reports iproto connections number.
> ---
> https://github.com/tarantool/tarantool/tree/i.kosarev/gh-3905-report-connections-number
> https://github.com/tarantool/tarantool/issues/3905
> 
> Changes in v7:
> - reduced line length in commit message

Please in future retain full change log, like this:

Changes in v7:
 - reduced line length in commit message
Changes in v6:
 - added docbot request to commit message
Changes in v5:
 - review-based polishing
Changes in v4:
 - CONNECTIONS counter doesn't have extra lua tables inside anymore
 - refactoring
...

It's nice to see how the patch evolved.

> 
>  src/box/iproto.cc          |  6 ++++++
>  src/box/iproto.h           |  6 ++++++
>  src/box/lua/stat.c         |  9 +++++++++
>  test/box/stat_net.result   | 37 +++++++++++++++++++++++++++++++++++++
>  test/box/stat_net.test.lua | 13 +++++++++++++
>  5 files changed, 71 insertions(+)
> 

Pushed to 2.1 and 1.10. Thanks!