From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 28 Feb 2019 14:09:14 +0300 From: Vladimir Davydov Subject: Re: [PATCH 1/2] vinyl: refactor vy_mem_iterator_seek Message-ID: <20190228110914.vnjhl2ojhlipqthl@esperanza> References: <3295f9b656c0dcb116de25dea7c87b67b647ca37.1551302815.git.vdavydov.dev@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3295f9b656c0dcb116de25dea7c87b67b647ca37.1551302815.git.vdavydov.dev@gmail.com> To: kostja@tarantool.org Cc: tarantool-patches@freelists.org List-ID: On Thu, Feb 28, 2019 at 12:37:19AM +0300, Vladimir Davydov wrote: > - Don't pass iterator_type to vy_mem_iterator_seek and functions called > by it. Instead pass only a key and jump to the first statement > following the key according to the iterator search criteria. Turns > out this is enough for memory iterator implementation. > - Fold EQ check in vy_mem_iterator_seek to avoid code duplication. > - Drop vy_mem_iterator_start and use vy_mem_iterator_seek directly. > --- > https://github.com/tarantool/tarantool/commits/dv/vy-optimize-next-key Pushed to 2.1. Will backport to 1.10 once stability test passes.