From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Date: Tue, 26 Feb 2019 14:17:23 +0300 From: Cyrill Gorcunov Subject: Re: [RFC v3] fiber: Increase default stack size Message-ID: <20190226111723.GN7198@uranus> References: <20190222201639.GA7198@uranus> <20190225145516.6fdmob3tdkft5sky@esperanza> <20190225213955.GI7198@uranus> <20190226085852.ugkqo6dz5nmjbhze@esperanza> <20190226091254.GL7198@uranus> <20190226102656.gwwy35jyaqdkci3l@esperanza> <20190226103659.oofo2bcnuztu44eg@esperanza> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190226103659.oofo2bcnuztu44eg@esperanza> To: Vladimir Davydov Cc: =?utf-8?B?0JPQtdC+0YDQs9C40Lkg0JrQuNGA0LjRh9C10L3QutC+?= , tarantool-patches@freelists.org List-ID: On Tue, Feb 26, 2019 at 01:36:59PM +0300, Vladimir Davydov wrote: > On Tue, Feb 26, 2019 at 01:26:56PM +0300, Vladimir Davydov wrote: > > - 1 MB for max stack size seems to be a bit of an overkill for now. > > The default value should be set to 256 KB, but we do need a > > configuration option for it. Let's add it to the fiber Lua module. > > May be done in a separate patch, but should be submitted together in > > the same patch set. > > Almost forgot. We should also print a warning to the log if some fiber > has gone too close to the stack limit (say half of the max allocation) > to indicate that the max stack size should be increased. Do we have something similar to printf_ratelimited() so we wouldn't spam a user too much?