From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 26 Feb 2019 13:27:37 +0300 From: Konstantin Osipov Subject: Re: [tarantool-patches] Re: [PATCH 2/2] Move 'core' and 'uuid' libs to src/lib Message-ID: <20190226102737.GA5592@chai> References: <20190226083033.GE2696@chai> <2f04d991-10c2-ba20-9624-8ae2cf425069@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2f04d991-10c2-ba20-9624-8ae2cf425069@tarantool.org> To: Vladislav Shpilevoy Cc: tarantool-patches@freelists.org, vdavydov.dev@gmail.com List-ID: * Vladislav Shpilevoy [19/02/26 12:41]: > On 26/02/2019 11:30, Konstantin Osipov wrote: > > * Vladislav Shpilevoy [19/02/26 00:59]: > > > For the same reason why 'uri' was moved to src/lib - SWIM needs > > > core and uuid, and SWIM will live in src/lib. > > > > > > This commit follows 'uri' relocation as a separate one because > > > 'uri' relocation required some changes in the files, moved by > > > this commit. > > > > The patch itself is looking good to me, it's a pity collation > > library depends on the core, I would perhaps make it separate if > > possible, but we're doing swim after all, right? > > > > The same applies to http parser. > > Citing your own words - you said, that we do not need to split > libraries now. For SWIM it is enough to just move existing uri > and core libraries into src/lib, without any changes inside the > latter. > > But if you want to extract collation and http, I can do that. > Should I? Up to you. If you find it easy to do (within 1 hour of your time for each patch) - please don't postpone it. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov