From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 26 Feb 2019 11:30:33 +0300 From: Konstantin Osipov Subject: Re: [tarantool-patches] [PATCH 2/2] Move 'core' and 'uuid' libs to src/lib Message-ID: <20190226083033.GE2696@chai> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: To: tarantool-patches@freelists.org Cc: vdavydov.dev@gmail.com List-ID: * Vladislav Shpilevoy [19/02/26 00:59]: > For the same reason why 'uri' was moved to src/lib - SWIM needs > core and uuid, and SWIM will live in src/lib. > > This commit follows 'uri' relocation as a separate one because > 'uri' relocation required some changes in the files, moved by > this commit. The patch itself is looking good to me, it's a pity collation library depends on the core, I would perhaps make it separate if possible, but we're doing swim after all, right? The same applies to http parser. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov