From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 097CA26371 for ; Tue, 26 Feb 2019 03:27:05 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sSjb9zTTbWo2 for ; Tue, 26 Feb 2019 03:27:04 -0500 (EST) Received: from smtp18.mail.ru (smtp18.mail.ru [94.100.176.155]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id B2C272626D for ; Tue, 26 Feb 2019 03:27:04 -0500 (EST) Date: Tue, 26 Feb 2019 11:27:02 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH v2 5/5] sql: remove field nErr of struct Parse Message-ID: <20190226082702.GC2696@chai> References: <4189982e3c44b8dcdd1fe3358c1b42f30fa6d6d2.1551114402.git.imeevma@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4189982e3c44b8dcdd1fe3358c1b42f30fa6d6d2.1551114402.git.imeevma@gmail.com> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: korablev@tarantool.org * imeevma@tarantool.org [19/02/25 20:16]: > At the moment, the only purpose of the field nErr of struct Parse > is to show whether the field rc of the same struct is > SQL_TARANTOOL_ERROR RC or not. Let's remove it. Generally, the entire stack is looking good. Nikita, whatever you find, please let's do it in a separate patchset, or please fix the issues yourself before pushing. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov