From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id C55E826371 for ; Tue, 26 Feb 2019 03:25:51 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id f7X08lp1TDCz for ; Tue, 26 Feb 2019 03:25:51 -0500 (EST) Received: from smtp37.i.mail.ru (smtp37.i.mail.ru [94.100.177.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 7A08F2626D for ; Tue, 26 Feb 2019 03:25:51 -0500 (EST) Date: Tue, 26 Feb 2019 11:25:49 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH v2 3/5] sql: save SQL parser errors in diag_set() Message-ID: <20190226082549.GB2696@chai> References: <85c9010267eba42be66e8c945d2b69098238a979.1551114402.git.imeevma@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: Imeev Mergen * n.pettik [19/02/26 10:06]: > > + /*186 */_(ER_SQL_PARSER_GENERIC, "%s") \ > > Hmm, what is this? This is a catch-all for all the errors we don't have time to classify and prettify now. I suggested the same approach for all the remaining sqlite errors: add a few catch-all tarantool error codes which we will refine and deprecate after box.sql.execute() removal is in. Let's not forget the original patch that triggered this refactoring, I want to push it asap as well. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov