From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 4DC4E26371 for ; Tue, 26 Feb 2019 03:24:08 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gHUHZaK0mqfE for ; Tue, 26 Feb 2019 03:24:08 -0500 (EST) Received: from smtp51.i.mail.ru (smtp51.i.mail.ru [94.100.177.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 7DF752626D for ; Tue, 26 Feb 2019 03:24:07 -0500 (EST) Date: Tue, 26 Feb 2019 11:24:05 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH v2 2/5] sql: rework syntax errors Message-ID: <20190226082405.GA2696@chai> References: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: Imeev Mergen * n.pettik [19/02/25 23:05]: > Quite strange name for err code. > I’d rather say ER_SQL_UNRECOGNIZED_SYMBOL/SYNTAX. > Is this message suggested by Konstantin? To be honest, I would > prefer old one. “Unrecognized syntax” doesn’t sound good and clear enough, > at least for me. Personally I would say “Syntax error near %s”. > The last one is used in several DBs, so I suppose it is common way to raise > errors like that. Yes, the name is suggested by me. There is a name clash with a generic ER_SYNTAX_ERROR. I also requested to add line/character numbers to the error message, which I don't see in the patch. Mergen, did you find that this is not possible to do? -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov