From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 25 Feb 2019 18:07:15 +0300 From: Vladimir Davydov Subject: Re: [PATCH v2] iproto: close socket explicitly before wal_dir at exit Message-ID: <20190225150715.kpferqdtrf3deve3@esperanza> References: <20190225145625.10840-1-i.kosarev@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190225145625.10840-1-i.kosarev@tarantool.org> To: Ilya Kosarev Cc: tarantool-patches@freelists.org, i.kosarev@corp.mail.ru, Ilya Kosarev List-ID: On Mon, Feb 25, 2019 at 05:56:25PM +0300, Ilya Kosarev wrote: > From: Ilya Kosarev > > tarantool instance didn't close socket explicitly > which could cause hot standby instance to fail to bind > in case it tries to bind before socket is closed by OS. > Now it is fixed by closing socket explicitly before wal_dir. > > Closes #3967 > --- > https://github.com/tarantool/tarantool/tree/i.kosarev/gh-3967-close-socket-explicitly > https://github.com/tarantool/tarantool/issues/3967 Please write a brief change log whenever you resubmit a patch and bump the version in the subject. For more details, see https://tarantool.io/en/doc/1.10/dev_guide/developer_guidelines/#how-to-submit-a-patch-for-review > > src/box/box.cc | 1 + > src/box/iproto.cc | 13 +++++++++++++ > src/box/iproto.h | 3 +++ > 3 files changed, 17 insertions(+) I pushed the patch to 2.1 and 1.10. Thanks.