From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vdavydov.dev@gmail.com>
Date: Mon, 25 Feb 2019 15:54:12 +0300
From: Vladimir Davydov <vdavydov.dev@gmail.com>
Subject: Re: [tarantool-patches] [PATCH v2] lua/fiber: Fix abort on malformed
 join input
Message-ID: <20190225125412.6cepuqwvdiutmdvt@esperanza>
References: <20190223133442.GC7198@uranus>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190223133442.GC7198@uranus>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tarantool-patches@freelists.org, =?utf-8?B?0JPQtdC+0YDQs9C40Lkg0JrQuNGA0LjRh9C10L3QutC+?= <georgy@tarantool.org>
List-ID: <tarantool-patches.dev.tarantool.org>

On Sat, Feb 23, 2019 at 04:34:42PM +0300, Cyrill Gorcunov wrote:
> If I create a new fiber and the join to himself we get an abort:
> 
>  | tarantool> f = require('fiber')
>  | ---
>  | ...
>  |
>  | tarantool> f.join(f.self())
>  | tarantool: src/fiber.c:407: fiber_join: Assertion `fiber->flags & FIBER_IS_JOINABLE' failed.
>  | Aborted (core dumped)
> 
> we should better throw an error.

Pushed to 2.1 and 1.10. Thanks!

> 
> v2: by georgy@
>  - add a testcase

We don't include changelog in the commit message. Please put it after
the diff separator (---) so that it is ignored by git-am.

> 
> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>

We don't sign-off patches :-)

> ---
>  src/lua/fiber.c         |    6 +++++-
>  test/app/fiber.result   |   11 +++++++++++
>  test/app/fiber.test.lua |    7 +++++++
>  3 files changed, 23 insertions(+), 1 deletion(-)