From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id B9EF426EAA
	for <tarantool-patches@freelists.org>; Mon, 25 Feb 2019 07:52:41 -0500 (EST)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id z9L8LDD1iNYC for <tarantool-patches@freelists.org>;
	Mon, 25 Feb 2019 07:52:41 -0500 (EST)
Received: from smtp29.i.mail.ru (smtp29.i.mail.ru [94.100.177.89])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 2D96C2264A
	for <tarantool-patches@freelists.org>; Mon, 25 Feb 2019 07:52:41 -0500 (EST)
Date: Mon, 25 Feb 2019 15:52:38 +0300
From: Kirill Yukhin <kyukhin@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH] sql: inherit global parameters for
 vinyl spaces
Message-ID: <20190225125238.ewtbn7khx4vbue4n@tarantool.org>
References: <20190220145340.5402-1-korablev@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20190220145340.5402-1-korablev@tarantool.org>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org
Cc: v.shpilevoy@tarantool.org, Nikita Pettik <korablev@tarantool.org>

Hello,

On 20 Feb 17:53, Nikita Pettik wrote:
> It is possible to create vinyl tables, if pragma sql_default_engine is
> set to corresponding engine. However, such spaces don't inherit global
> vinyl-specific options which can be set by box.cfg{}. Lets fix it and
> during encoding of index options fetch appropriate configurations from
> cfg.
> 
> Closes #3912
> ---
> Branch: https://github.com/tarantool/tarantool/tree/np/gh-3912-sql-vinyl-inherit-params
> Issue: https://github.com/tarantool/tarantool/issues/3912

I've checked yout patch into 2.1 branch.

--
Regards, Kirill Yukhin