From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id CBC9826AF7 for ; Mon, 25 Feb 2019 06:29:39 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id J-D2b0JTyqSL for ; Mon, 25 Feb 2019 06:29:39 -0500 (EST) Received: from smtp49.i.mail.ru (smtp49.i.mail.ru [94.100.177.109]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 8814426A96 for ; Mon, 25 Feb 2019 06:29:39 -0500 (EST) Date: Mon, 25 Feb 2019 14:29:36 +0300 From: Kirill Yukhin Subject: [tarantool-patches] Re: [PATCH 0/2] Compute derived collation for concatenation Message-ID: <20190225112936.7aciu2efh6kuteq5@tarantool.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: v.shpilevoy@tarantool.org, Nikita Pettik Hello, On 16 Jan 16:13, Nikita Pettik wrote: > Branch: https://github.com/tarantool/tarantool/tree/np/gh-3937-concatenation-collation > Issue: https://github.com/tarantool/tarantool/issues/3937 > > According to ANSI concatenation operator should derive collation > from its operands. This small patch-set implements this procedure > according to rules described in SQL standard. > > Nikita Pettik (2): > sql: refactor sql_expr_coll and sql_binary_compare_coll_seq functions > sql: compute resulting collation for concatenation > > src/box/sql/expr.c | 125 +++++++++++++++++++++++++++++--------------- > src/box/sql/select.c | 27 ++++++---- > src/box/sql/sqliteInt.h | 14 +++-- > src/box/sql/where.c | 56 ++++++++++---------- > src/box/sql/whereexpr.c | 23 ++++---- > test/sql/collation.result | 102 ++++++++++++++++++++++++++++++++++++ > test/sql/collation.test.lua | 46 ++++++++++++++++ > 7 files changed, 296 insertions(+), 97 deletions(-) Your patches were pushed into 2.1 branch few days ago. -- Regards, Kirill Yukhin