From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 13060285F9 for ; Sat, 23 Feb 2019 04:54:18 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MKqb6AFoeomh for ; Sat, 23 Feb 2019 04:54:17 -0500 (EST) Received: from smtp55.i.mail.ru (smtp55.i.mail.ru [217.69.128.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 4B585285F5 for ; Sat, 23 Feb 2019 04:54:17 -0500 (EST) Received: by smtp55.i.mail.ru with esmtpa (envelope-from ) id 1gxU0c-0008UZ-VG for tarantool-patches@freelists.org; Sat, 23 Feb 2019 12:54:15 +0300 Date: Sat, 23 Feb 2019 12:54:14 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH] vinyl: fix crash in run iterator due to uninitialized variable Message-ID: <20190223095414.GA12939@chai> References: <79bd523e8551f665c9d2b85c37e42ff809c7ba10.1550870228.git.vdavydov.dev@gmail.com> <20190222211752.pfgav72gei2uczlh@esperanza> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190222211752.pfgav72gei2uczlh@esperanza> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org * Vladimir Davydov [19/02/23 12:44]: > On Sat, Feb 23, 2019 at 12:17:30AM +0300, Vladimir Davydov wrote: > > vy_run_iterator_seek left the return statement uninitialized under > > certain conditions. The branch in the code wasn't covered by any test, > > because it could only be triggered by an EQ SELECT following range > > coalescing, so we only saw it when a customer reported a crash. > > Fix it and improve vinyl/select_consistency test to cover this branch. > > This one is urgent. Pushed to 2.1 and 1.10. Thanks! -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov