From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Sat, 23 Feb 2019 00:17:52 +0300 From: Vladimir Davydov Subject: Re: [PATCH] vinyl: fix crash in run iterator due to uninitialized variable Message-ID: <20190222211752.pfgav72gei2uczlh@esperanza> References: <79bd523e8551f665c9d2b85c37e42ff809c7ba10.1550870228.git.vdavydov.dev@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <79bd523e8551f665c9d2b85c37e42ff809c7ba10.1550870228.git.vdavydov.dev@gmail.com> To: tarantool-patches@freelists.org List-ID: On Sat, Feb 23, 2019 at 12:17:30AM +0300, Vladimir Davydov wrote: > vy_run_iterator_seek left the return statement uninitialized under > certain conditions. The branch in the code wasn't covered by any test, > because it could only be triggered by an EQ SELECT following range > coalescing, so we only saw it when a customer reported a crash. > Fix it and improve vinyl/select_consistency test to cover this branch. This one is urgent. Pushed to 2.1 and 1.10.