From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Fri, 22 Feb 2019 21:26:18 +0300 From: Konstantin Osipov Subject: Re: [tarantool-patches] [PATCH 1/3] salad: make heap struct more friendly to use Message-ID: <20190222182618.GB1691@chai> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: To: tarantool-patches@freelists.org Cc: vdavydov.dev@gmail.com List-ID: * Vladislav Shpilevoy [19/02/22 14:39]: > Now heap API works with struct heap_node only, which forces a > user to constantly call container_of. Such a code looks really > awful. This commit makes heap taking and returning user defined > structures, and removes container_of clue. > > It is worth noting, that the similar API rb-tree and b-tree > have. Even rlist has its rlist_*_entry() wrappers, and mhash > provides macroses to define your own value type. OK to push. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov