From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 5571C27A4E for ; Fri, 22 Feb 2019 13:22:22 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id B6yoB5dB4vEq for ; Fri, 22 Feb 2019 13:22:22 -0500 (EST) Received: from smtp61.i.mail.ru (smtp61.i.mail.ru [217.69.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 0272E20566 for ; Fri, 22 Feb 2019 13:22:21 -0500 (EST) Date: Fri, 22 Feb 2019 21:22:19 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH v1 1/4] box: introduce new helpers in column_mask.h Message-ID: <20190222182219.GA1691@chai> References: <20190222180101.GB12852@chai> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190222180101.GB12852@chai> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: v.shpilevoy@tarantool.org, Kirill Shcherbatov * Konstantin Osipov [19/02/22 21:02]: > The patch otherwise looks good to me. Checked Vlad's review, I agree with Vlad one should not introduce helpers without starting to use them. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov