From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 21 Feb 2019 16:26:54 +0300 From: Vladimir Davydov Subject: Re: [PATCH v2 1/4] box: move memtx_tree implementation to source file Message-ID: <20190221132654.hbaanli7s3ey4f2w@esperanza> References: <0e4dceb9b4dd6ae72bca08823ad7b5a8a6f85ce6.1550050245.git.kshcherbatov@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0e4dceb9b4dd6ae72bca08823ad7b5a8a6f85ce6.1550050245.git.kshcherbatov@tarantool.org> To: Kirill Shcherbatov Cc: tarantool-patches@freelists.org, kostja@tarantool.org List-ID: The subject line prefix should be 'memtx:' I think. On Wed, Feb 13, 2019 at 12:32:25PM +0300, Kirill Shcherbatov wrote: > Refactored memtx_tree code so that memtx_tree.h contained only > the signature of the tree object constructor memtx_tree_index_new, > while all implementation details were in memtx_tree.c. > This will further allow to template the implementation details. > > Needed for #3961 > --- > src/box/memtx_tree.c | 62 ++++++++++++++++++++++++++++++++++++++-- > src/box/memtx_tree.h | 68 ++------------------------------------------ > 2 files changed, 63 insertions(+), 67 deletions(-) The patch is good, but I think we shouldn't stop at memtx_tree and do the same for other memtx indexes - hash, bitset, rtree. Please do it in the scope of this patch.