From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vdavydov.dev@gmail.com>
Date: Thu, 21 Feb 2019 14:52:45 +0300
From: Vladimir Davydov <vdavydov.dev@gmail.com>
Subject: Re: [tarantool-patches] Re: [PATCH 06/12] vinyl: move vy_key_dup to
 generic code
Message-ID: <20190221115245.bhzyb2ktom5vvjln@esperanza>
References: <cover.1550744027.git.vdavydov.dev@gmail.com>
 <3735b650cb3759eb7f48f4689aa9d784ca08f534.1550744027.git.vdavydov.dev@gmail.com>
 <20190221110412.GF3872@chai>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190221110412.GF3872@chai>
To: Konstantin Osipov <kostja@tarantool.org>
Cc: tarantool-patches@freelists.org
List-ID: <tarantool-patches.dev.tarantool.org>

On Thu, Feb 21, 2019 at 02:04:12PM +0300, Konstantin Osipov wrote:
> * Vladimir Davydov <vdavydov.dev@gmail.com> [19/02/21 13:31]:
> > This helper function has nothing to do with vinyl - it's simply
> > duplicates a msgpack array. Let's move it to tuple.c and rename
> > it to key_dup.
> 
> Why to tuple.c and not in to msgpack? 

Because there's no place for msgpack helpers inside tarantool. Besides,
other functions operating on raw keys (which are msgpack arrays) have
key_ prefix, e.g. key_compare.

> 
> I don't like what this function is doing and how it's doing it, so
> I'd rather bury it in vinyl or get rid of it, not make a generic
> one.

OK. I just wanted to expel it from vinyl code so as to avoid confusion
between vinyl key statement and raw key msgpack.