From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id B5EDE27C25 for ; Thu, 21 Feb 2019 06:16:36 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1RHG9tM6uee1 for ; Thu, 21 Feb 2019 06:16:36 -0500 (EST) Received: from smtp31.i.mail.ru (smtp31.i.mail.ru [94.100.177.91]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 6FA8627C21 for ; Thu, 21 Feb 2019 06:16:36 -0500 (EST) Received: from [185.6.245.178] (port=55074 helo=atlas.local) by smtp31.i.mail.ru with esmtpa (envelope-from ) id 1gwmLC-0002Hd-Lt for tarantool-patches@freelists.org; Thu, 21 Feb 2019 14:16:34 +0300 Date: Thu, 21 Feb 2019 14:16:34 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH 11/12] vinyl: don't use IPROTO_SELECT type for key statements Message-ID: <20190221111634.GK3872@chai> References: <7498850a28f6b3f2e7740f9f9060f6bee6909145.1550744027.git.vdavydov.dev@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7498850a28f6b3f2e7740f9f9060f6bee6909145.1550744027.git.vdavydov.dev@gmail.com> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org * Vladimir Davydov [19/02/21 13:31]: > To differentiate between key and tuple statements in comparators, we set > IPROTO_SELECT type for key statements. As a result, we can't use key > statements in the run iterator directly although secondary index runs do > store statements in key format. Instead we create surrogate tuples > filling missing fields with NULLs. This won't play nicely with multikey > indexes so we need to teach iterators to deal with statements in key > format. The first step in this direction is dropping IPROTO_SELECT and > starting to identify key statements by format instead. It's amazing how simple this patch is, it's OK to push provided we decide to push the final patch. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov