From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id E739027C19 for ; Thu, 21 Feb 2019 06:15:32 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id J2NhjTnhix1R for ; Thu, 21 Feb 2019 06:15:32 -0500 (EST) Received: from smtp62.i.mail.ru (smtp62.i.mail.ru [217.69.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id A767C27BFA for ; Thu, 21 Feb 2019 06:15:32 -0500 (EST) Received: from [185.6.245.178] (port=55072 helo=atlas.local) by smtp62.i.mail.ru with esmtpa (envelope-from ) id 1gwmKB-0000no-1Y for tarantool-patches@freelists.org; Thu, 21 Feb 2019 14:15:31 +0300 Date: Thu, 21 Feb 2019 14:15:30 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH 10/12] vinyl: rename key stmt construction routine Message-ID: <20190221111530.GJ3872@chai> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org * Vladimir Davydov [19/02/21 13:31]: > Currently, it's called vy_stmt_new_select, but soon a key statement will > be allowed to have any type, not just IPROTO_SELECT. So let's rename it > to vy_stmt_new_key. Let's also rename the wrapper vy_key_from_msgpack to > vy_stmt_new_key_from_array, because its key feature is that in contrast > to vy_stmt_new_key it takes a msgpack array instead of key data + part > count. I like the new names, vy_stmt_new_key_from_array - maybe vy_stmt_new_key_from_msgpack after all? -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov