From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 11FE027BE1 for ; Thu, 21 Feb 2019 06:04:14 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BaxddyXAMlcw for ; Thu, 21 Feb 2019 06:04:13 -0500 (EST) Received: from smtp29.i.mail.ru (smtp29.i.mail.ru [94.100.177.89]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id BCB9727A3B for ; Thu, 21 Feb 2019 06:04:13 -0500 (EST) Received: from [185.6.245.178] (port=33758 helo=atlas.local) by smtp29.i.mail.ru with esmtpa (envelope-from ) id 1gwm9E-0004Sz-5s for tarantool-patches@freelists.org; Thu, 21 Feb 2019 14:04:12 +0300 Date: Thu, 21 Feb 2019 14:04:12 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH 06/12] vinyl: move vy_key_dup to generic code Message-ID: <20190221110412.GF3872@chai> References: <3735b650cb3759eb7f48f4689aa9d784ca08f534.1550744027.git.vdavydov.dev@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3735b650cb3759eb7f48f4689aa9d784ca08f534.1550744027.git.vdavydov.dev@gmail.com> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org * Vladimir Davydov [19/02/21 13:31]: > This helper function has nothing to do with vinyl - it's simply > duplicates a msgpack array. Let's move it to tuple.c and rename > it to key_dup. Why to tuple.c and not in to msgpack? I don't like what this function is doing and how it's doing it, so I'd rather bury it in vinyl or get rid of it, not make a generic one. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov