From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id D445327BA8 for ; Thu, 21 Feb 2019 06:02:46 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yKwPxEXd2rAn for ; Thu, 21 Feb 2019 06:02:46 -0500 (EST) Received: from smtp14.mail.ru (smtp14.mail.ru [94.100.181.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 8D60E20F33 for ; Thu, 21 Feb 2019 06:02:46 -0500 (EST) Received: from [185.6.245.178] (port=33744 helo=atlas.local) by smtp14.mail.ru with esmtpa (envelope-from ) id 1gwm7o-0007ng-Rb for tarantool-patches@freelists.org; Thu, 21 Feb 2019 14:02:44 +0300 Date: Thu, 21 Feb 2019 14:02:44 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH 05/12] vinyl: move vy_tuple_key_contains_null to generic code Message-ID: <20190221110244.GE3872@chai> References: <51872a8755aa2bc223103ab76f839b7df38f1fcb.1550744027.git.vdavydov.dev@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <51872a8755aa2bc223103ab76f839b7df38f1fcb.1550744027.git.vdavydov.dev@gmail.com> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org * Vladimir Davydov [19/02/21 13:31]: > The function doesn't require any knowledge of vinyl statement layout and > can work on regular tuples. Let's rename it to tuple_key_contains_null, > move its implementation to tuple_extract_key.cc, and declare it in > key_def.h, as we do with other similar functions. OK to push. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov