From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 2704726BAB for ; Wed, 20 Feb 2019 13:25:24 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id g3Kh-U7QGDCn for ; Wed, 20 Feb 2019 13:25:24 -0500 (EST) Received: from smtp52.i.mail.ru (smtp52.i.mail.ru [94.100.177.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id D346E26B6C for ; Wed, 20 Feb 2019 13:25:23 -0500 (EST) Date: Wed, 20 Feb 2019 21:25:21 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH 4/4] sql: raise integer overflow error during msgpack decode Message-ID: <20190220182521.GE3412@chai> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: v.shpilevoy@tarantool.org, Nikita Pettik * Nikita Pettik [19/02/20 15:12]: > Since previous commit allows us to raise an error during msgpack decode > inside VDBE, lets do this if decoded integer is out of > [INT64_MIN, INT64_MAX] range and set "integer is overflowed" diagnostic > message. This looks OK as interim approach to close 3735, but can't be accepted as a production-level fix. If SQL can't handle uint64_t range, SQL tables should not be able to store values from this range, i.e. there should be an implicitly created constraint on SQL tables. Better yet is to make sure SQL can handle entire tarantool range by changing vdbe to emit uint64-range-aware instructions. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov