From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 6181B2746D for ; Tue, 19 Feb 2019 10:04:44 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id iOAOIOD-s-3B for ; Tue, 19 Feb 2019 10:04:44 -0500 (EST) Received: from smtp56.i.mail.ru (smtp56.i.mail.ru [217.69.128.36]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 199D42740F for ; Tue, 19 Feb 2019 10:04:44 -0500 (EST) Date: Tue, 19 Feb 2019 18:04:41 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH v2 2/2] sql: rework "no such object" and "object exists" errors Message-ID: <20190219150441.GC2503@chai> References: <03c4d38a6b676a41d9b9cb094479c90d9a99c12d.1550250721.git.imeevma@gmail.com> <43CF0F9C-EC0A-4C04-A60F-2103CBBE3CAA@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <43CF0F9C-EC0A-4C04-A60F-2103CBBE3CAA@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: Imeev Mergen , Kirill Yukhin * n.pettik [19/02/18 15:16]: > > > > On 15 Feb 2019, at 20:14, imeevma@tarantool.org wrote: > > > > Hi! Thank you for review. My answers and new version below. There > > will not be diff between versions because the only meaningful fix > > was turned into new patch in the patch-set. > > Ok, if Konstantin and you consider my comments as minor ones, > then I don’t mind if this part is pushed to 2.1 (Travis is OK, refactoring > is obvious). > > Kirill, could you do this? I assume your comments are being worked on in separate commits. > -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov