From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 19 Feb 2019 18:01:56 +0300 From: Konstantin Osipov Subject: Re: [tarantool-patches] Re: [PATCH v2 4/4] box: introduce tuple compare hint for string index Message-ID: <20190219150156.GB2503@chai> References: <48f09c5c8f53bfa63a52da90ffe4672ade7ad9ae.1550050245.git.kshcherbatov@tarantool.org> <414fffe7-3d58-fd42-3334-d7072c78afb4@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <414fffe7-3d58-fd42-3334-d7072c78afb4@tarantool.org> To: tarantool-patches@freelists.org Cc: vdavydov.dev@gmail.com, Alexandr Lyapunov List-ID: * Kirill Shcherbatov [19/02/15 21:36]: > Hi! I've implemented Kostya's concepts for compatible hints for UINT/INT. > Also fixed nullability troubles. Now alter looks fine for me. > I've thought about number/integer convertions, but such alter would not pass, > I guess. > Do you have tests for this or have you checked that specific tests exist? E.g. when tuple hint is used *and* we change nullability back and forth. BTW, have you checked changes in collation, do they work? -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov