From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id BD678258FF for ; Mon, 18 Feb 2019 05:28:08 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lLQj2IDY1Rdd for ; Mon, 18 Feb 2019 05:28:08 -0500 (EST) Received: from smtp52.i.mail.ru (smtp52.i.mail.ru [94.100.177.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 2217525A03 for ; Mon, 18 Feb 2019 05:28:08 -0500 (EST) Date: Mon, 18 Feb 2019 13:28:05 +0300 From: Kirill Yukhin Subject: [tarantool-patches] Re: [PATCH v4 1/2] sql: remove useless pragmas Message-ID: <20190218102805.rg4lj5qflig3m5hd@tarantool.org> References: <20190212073151.27230-1-szudin@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190212073151.27230-1-szudin@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: korablev@tarantool.org, Stanislav Zudin Hello, On 12 Feb 10:31, Stanislav Zudin wrote: > The pragmas "query_only" and "read_uncommitted" didn't affect anything > and were removed. > Fixed an error in pragma index_list which caused a segmantation fault. > pragma sql_default_engine accepts only strings. > Thus pragma sql_default_engine('memtx') is a well-formed command, > while pragma sql_default_engine(memtx) or > pragma sql_default_engine("memtx") are considered as ill-formed and > raise an error. > > Closes #3733 > --- > Branch: https://github.com/tarantool/tarantool/tree/stanztt/gh-3733-obsolete-pragmas > Issue: https://github.com/tarantool/tarantool/issues/3733 I've checked your patch into 2.1 branch. --- Regards, Kirill Yukhin